| To: | davem@xxxxxxxxxx |
|---|---|
| Subject: | [PATCH 2.6] ipconfig accepts any DHCPACK |
| From: | Peter Buckingham <peter@xxxxxxxxxxxx> |
| Date: | Tue, 07 Sep 2004 14:46:14 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4 |
Hi David,I was playing around with using ipconfig to initialise a bunch of systems and it turns out that the ipconfig code doesn't check to see whether the ACK is for it or another system. I've just added a simple check to compare the hardware address of the device to the one in the packet.
peter
Signed-off-by: Peter Buckingham <peter@xxxxxxxxxxxx>
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-02 14:53:54.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-02 14:57:49.000000000 -0700
@@ -966,6 +966,12 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
+ for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
+ && (i < 16); i++);
+ if (i < 16)
+ goto drop_unlock;
+
/* Yeah! */
break;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] NETIF_F_LLTX for devices 2, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH] NETIF_F_LLTX for devices 2, jamal |
| Previous by Thread: | schedule_work, a summary, Andy Fleming |
| Next by Thread: | Re: [PATCH 2.6] ipconfig accepts any DHCPACK, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |