netdev
[Top] [All Lists]

Re: [PATCH 2.6] watch64: generic variable monitoring system

To: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6] watch64: generic variable monitoring system
From: Jeff Sipek <jeffpc@xxxxxxxxxxxxx>
Date: Fri, 03 Sep 2004 16:24:15 -0400
Cc: netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20040904.040727.72671952.yoshfuji@xxxxxxxxxxxxxx>
References: <200409031307.01240.jeffpc@xxxxxxxxxxxxx> <200409031319.24863.jeffpc@xxxxxxxxxxxxx> <20040904.040727.72671952.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.6.2
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 03 September 2004 15:07, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> I agree with the basic principle; it is very similar to mine.

Yes, I saw a patch on lkml a while a go (possibly yours?) that used a 
workqueue (IIRC.)

> However, it is too complicated isn't it?

I considered the option of removing the capability of the programmer asking 
for a certain interval, and instead having all the variables checked every 
WATCH64_INTERVAL. 

> I would do per-"table" registration (instead of per-variable one);

I considered that option, but then decided to make the watch64 system generic 
enough so that it could be used from anywhere in the kernel. Is my idea of 
having a kernel-wide subsystem like this too heavy-weight?

> watch64_getval() seems very ugly to me...

How so? Is it the multiplicity of "if (!st)"?

Jeff.

- -- 
bad pun of the week: the formula 1 control computer suffered from a race 
condition
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBONLzwFP0+seVj/4RAvYsAKCdVy9EzivcGtwa9CDiuvy/nwWuJwCglQ4L
iIf4QXC7PA+YwQs3905sRv0=
=NkA4
-----END PGP SIGNATURE-----


<Prev in Thread] Current Thread [Next in Thread>