netdev
[Top] [All Lists]

Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msl

To: netdev@xxxxxxxxxxx
Subject: Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep()
From: margitsw@xxxxxxxxxxx (Margit Schubert-While)
Date: Thu, 2 Sep 2004 19:30:18 +0200
Cc: janitor@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Thu, 02 Sep 2004, Nishanth scribeth:
> A grep of drivers/net/wireless/prism54 for schedule_timeout showed three
> occurrences (in 2.6.9-rc1-bk7):
> islpci_dev.c:   schedule_timeout(50*HZ/1000);
> islpci_dev.c:           remaining = schedule_timeout(HZ);
> islpci_mgt.c:           timeleft = schedule_timeout(wait_cycle_jiffies);
> The first is removed by my patch.
> The second & third are potentially bugs as there is no
> set_current_state() preceding the call to schedule_timeout(). As per the
> source:

Nope, look a few lines above:
DEFINE_WAIT() and prepare_to_wait().

Margit


<Prev in Thread] Current Thread [Next in Thread>