netdev
[Top] [All Lists]

Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msl

To: netdev@xxxxxxxxxxx
Subject: Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep()
From: margitsw@xxxxxxxxxxx (Margit Schubert-While)
Date: Thu, 2 Sep 2004 12:21:42 +0200
Cc: janitor@xxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Thu, 02 Sep 2004, Maximilian scribeth:
> you didn't answer to the unit argument in favour of msleep.

Don't need to, here's msleep -
void msleep(unsigned int msecs)
{
        unsigned long timeout = msecs_to_jiffies(msecs);

        while (timeout) {
                set_current_state(TASK_UNINTERRUPTIBLE);
                timeout = schedule_timeout(timeout);
        }
}

In other words, with the subtle exception of the while loop,
it reconstitutes the original code.
(Although m_to_j doesn't even exactly do that)
(And note because of the while loop, this may not be 
 what the author intended)

> shure msleep is also consistent and documented.
grep -r Documentation = Nix

Margit


<Prev in Thread] Current Thread [Next in Thread>