[Top] [All Lists]

Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msl

To: Margit Schubert-While <margitsw@xxxxxxxxxxx>
Subject: Re: [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep()
From: maximilian attems <janitor@xxxxxxxxxxxxxx>
Date: Thu, 2 Sep 2004 10:24:33 +0200
Cc: netdev@xxxxxxxxxxx, kj <kernel-janitors@xxxxxxxx>
In-reply-to: <200409020850.38177.margitsw@xxxxxxxxxxx>
Mail-followup-to: Margit Schubert-While <margitsw@xxxxxxxxxxx>, netdev@xxxxxxxxxxx, kj <kernel-janitors@xxxxxxxx>
References: <200409020850.38177.margitsw@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Thu, 02 Sep 2004, Margit Schubert-While wrote:

> I agree with Jean and add the following :
> You are assuming HZ = 1000.
> In 2.4, HZ = 100 (And in 2.6, HZ is not necessarily = 1000).

but this is an argument for msleep as it uses msecs as unit,
which don't depend on your arch. 
(well physics says different for arch/relativistic :)

> The prism54 code base is identical between 2.4/2.6 and is
> maintained as such in the project.
> Therefore, I look forward to your implementation of msleep()
> in 2.4  ;-)

2.4 is closed for such stuff, you'll know that better than me,
it shouldn't hinder 2.6 in it's progression.
one day you will need to branch.

kernel janitor

<Prev in Thread] Current Thread [Next in Thread>