netdev
[Top] [All Lists]

ipmr_get_route()

To: netdev@xxxxxxxxxxx
Subject: ipmr_get_route()
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 30 Aug 2004 17:14:36 -0700
Sender: netdev-bounce@xxxxxxxxxxx
This is very broken.

It gets called only by rt_fill_info() to get multicast routing
information from ipmr.c, the skb it passes in is the rtnetlink
message.

But look at what ipmr_get_route() actually does.  If the cache
entry cannot be found, it tries to build an IPV4 packet using
this packet to resolve the missing cache entry!

I think we don't crash here only because most of the time the
user has not specified an explicit input interface in the route
lookup request, and therefore skb->dev is NULL when ipmr_get_route()
takes a look at it.

Nevertheless things are seriously busted here.  Any takers to
fix this thing up? :-)

<Prev in Thread] Current Thread [Next in Thread>
  • ipmr_get_route(), David S. Miller <=