netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27

from [Jeff Garzik] [Permanent Link][Original]
To: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Mon, 30 Aug 2004 13:33:00 -0400
Cc: Peter Holik <peter@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <200408301157.03334.vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <38386.192.168.1.2.1093850895.squirrel@xxxxxxxxxxxxxxxxxxxx> <200408301157.03334.vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803 
Denis Vlasenko wrote:

On Monday 30 August 2004 10:28, Peter Holik wrote:


static void set_rx_mode(struct net_device *dev)
{
  spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock;
  unsigned long flags;
  spin_lock_irqsave(lp, flags);
  __set_rx_mode(dev);
-  spin_unlock_irqrestore(&lp, flags);
+  spin_unlock_irqrestore(lp, flags);
}



Oh... it was my change which was buggy... Thanks for the fix!

Jeff, 2.6 most probably has the same bug.



Upstream 2.6 already has the fix...

        Jeff
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: Updated WE-18 (WPA) proposal, Jeff Garzik
Next by Date:  Re: Updated WE-18 (WPA) proposal, Jean Tourrilhes
Previous by Thread:  Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27, Denis Vlasenko
Next by Thread:  tg3 DMA RW Control register settings, Greg Banks
Indexes:  [Date] [Thread] [Top] [All Lists]