netdev
[Top] [All Lists]

Re: [PATCH] Allow setting dev->weight using ip(8)

To: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Subject: Re: [PATCH] Allow setting dev->weight using ip(8)
From: jamal <hadi@xxxxxxxxxx>
Date: 30 Aug 2004 08:27:40 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <5cac192f040830035669628d1@xxxxxxxxxxxxxx>
Organization: jamalopolous
References: <5cac192f040830035669628d1@xxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-08-30 at 06:56, Eric Lemoine wrote:
> Hello
> 
> For my own testing purposes, I often need to modify dev->weight. So I
> patched the kernel and iproute2 to be able to modify dev->weight using
> ip(8). After all, one can modify tx_queue_len so why not weight?
> 
> Two kernel patches attached: one using the ioctl framework and another
> using the rtnetlink framework. Warning: the attached rtnetlink patch
> is a superset of Thomas Graf's rtnetlink patch for setting mtu and
> tx_queue_len.
> 
> PS: both patches are against 2.6.5-rc3-ben0 but should apply to any 2.6.
> 

Looks sane.
Not sure if you should encourage ioctl though ;-> 
Out of curiosity, what/when do you change weight? I think its valuable
to do so, just curious. BTW, As Dave pointed out alwauIFLA_WEIGHT

missing user space/ip patch btw.

cheers,
jamal



<Prev in Thread] Current Thread [Next in Thread>