netdev
[Top] [All Lists]

Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27

To: "Peter Holik" <peter@xxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27
From: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 30 Aug 2004 11:57:02 +0300
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <38386.192.168.1.2.1093850895.squirrel@xxxxxxxxxxxxxxxxxxxx>
References: <38386.192.168.1.2.1093850895.squirrel@xxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Monday 30 August 2004 10:28, Peter Holik wrote:
> static void set_rx_mode(struct net_device *dev)
> {
>    spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock;
>    unsigned long flags;
>    spin_lock_irqsave(lp, flags);
>    __set_rx_mode(dev);
> -  spin_unlock_irqrestore(&lp, flags);
> +  spin_unlock_irqrestore(lp, flags);
> }

Oh... it was my change which was buggy... Thanks for the fix!

Jeff, 2.6 most probably has the same bug.
--
vda


<Prev in Thread] Current Thread [Next in Thread>