netdev
[Top] [All Lists]

Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 24 Aug 2004 11:55:41 -0700
Cc: jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040824110532.GA10241@xxxxxxxxxxxxxxxxxxx>
References: <20040824110532.GA10241@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 24 Aug 2004 21:05:32 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> The idea is simple.  None of the callers of skb_checksum are passing it
> skb's which are shared.  They may be cloned however.  But the application
> checksum is always in the skb header so there is no need to linearise it.

What about looping back of multicast packets via netif_rx(),
is that handled correctly too?

I only mention it because that is the case that causes
problems elsewhere.

I'm going to think over this later today some more.


<Prev in Thread] Current Thread [Next in Thread>