|Subject:||Re: Billing 1: WAS (Re: [PATCH 2/4] deferred drop, __parent workaround, reshape_fail , netdev@xxxxxxxxxxx ,|
|Date:||Mon, 23 Aug 2004 11:33:19 +0200|
|Cc:||Harald Welte <laforge@xxxxxxxxxxxxx>, devik@xxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx|
|References:||<411C0FCE.9060906@xxxxxxxxxxxx> <1092401484.1043.30.camel@xxxxxxxxxxxxxxxx> <20040816072032.GH15418@sunbeam2> <1092661235.2874.71.camel@xxxxxxxxxxxxxxxx> <4120D068.2040608@xxxxxxxxxxxx> <1092743526.1038.47.camel@xxxxxxxxxxxxxxxx> <41220AEA.20409@xxxxxxxxxxxx> <1093187835.1042.95.camel@xxxxxxxxxxxxxxxx>|
|User-agent:||Mozilla Thunderbird 0.7.3 (Windows/20040803)|
Apologies for latency - was busy at (my real) work.
you don't have to apologize for that :) it's something everybody can easily understand :)
Let me break this email into several ones since it is getting long. On Tue, 2004-08-17 at 09:40, sandr8 wrote:something like enqueue(dev) that will indirectly call dev->qdisc->enqueueand handle in that single place that stuff that does not fit well in net/core/dev.cEnqueue of _root_ qdisc is the place to do it. Maybe even dev.c calls to it. Lets defer this to the next email.
then i should add some code in every qdisc that can be root and execute it only if it is actually root? isn't it more complex?
Let me say this: I am happy with Haralds billing patch which is already in as is. In other words, although there is an accounting discrepancy it is not that big. What does that mean? unbilling is not something to rush in and patch in if its going to have an impact on other pieces. It doesnt matter whetherit goes in in 2.6.20 or doesnt even go in as far as i am concerned. However this shouldnt dicourage you because you have actually opened anissue we need to resolve. So please keep up the discussions.
sure, for the time being i thought to simply concentrate on the rest and maintain it as indipendent as possible from the choice that will be taken. cheers alessandro
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] Prevent crash on ip_conntrack removal, David S. Miller|
|Next by Date:||Re: Billing 3: WAS(Re: [PATCH 2/4] deferred drop, __parent workaround, reshape_fail , netdev@xxxxxxxxxxx ,, sandr8|
|Previous by Thread:||Billing 1: WAS (Re: [PATCH 2/4] deferred drop, __parent workaround, reshape_fail , netdev@xxxxxxxxxxx ,, jamal|
|Next by Thread:||Re: Billing 1: WAS (Re: [PATCH 2/4] deferred drop, __parent workaround, reshape_fail , netdev@xxxxxxxxxxx ,, Harald Welte|
|Indexes:||[Date] [Thread] [Top] [All Lists]|