| To: | prism54-devel@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH/RFC] set_rates support for prism54 |
| From: | margitsw@xxxxxxxxxxx (Margit Schubert-While) |
| Date: | Sun, 15 Aug 2004 15:21:25 +0200 |
| Cc: | vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, mcgrof@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
I disagree with this. We don't need parameter parsing either in the driver or in wireless.c. There is a perfectly good infrastructure in wireless tools iwpriv.c Take a look at around line 375 in iwpriv.c for the existing example of IW_PRIV_TYPE_FLOAT. This could be adapted for this purpose (IW_PRIV_TYPE_BITRATE ?) and (mis)use the iw_freq structure to pass the values and extra info. This is probably the least invasive and can be tied to a particular WE release. Also we seem to have forgotten the 5 GHz band with 72, 100, 108 rates and only ofdm allowable. Margit |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Openswan Users] Invalid argument NULL, Herbert Xu |
|---|---|
| Next by Date: | Re: kernel-2.6.8.1 EIP is at velocity_netdev_event+0x16/0x50, George Georgalis |
| Previous by Thread: | Re: [PATCH/RFC] set_rates support for prism54, Luis R. Rodriguez |
| Next by Thread: | Re: [Prism54-devel] Re: [PATCH/RFC] set_rates support for prism54, Denis Vlasenko |
| Indexes: | [Date] [Thread] [Top] [All Lists] |