Re: [PATCH] Move inetdev/ifa over to RCU

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Hi:

I'm just going through all the __in_dev_get() callers and the one
in ip_route_output_slow() looks fishy.  It appears to be checking
whether the subsequent inet_select_addr() calls will succeed or not.

But this is not reliable since the addresses can always disappear
between the check and the actual call.

Do we really care about the zero return value of inet_select_addr()
here? What about the other calls to inet_select_addr()?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt