netdev
[Top] [All Lists]

Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 11 Aug 2004 15:17:31 -0400
Cc: Andrew Morton <akpm@xxxxxxxx>, Pasi Sjoholm <ptsjohol@xxxxxxxxx>, Hector Martin <hector@xxxxxxxxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040805234336.A15407@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040805234336.A15407@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510
Francois Romieu wrote:
This patch allows to update the interrupt status register after an Rx overflow or a Rx fifo error even when the Rx buffer contains no packet.
As a side effect it saves a few heavy (i.e. flushed) pci ops per received
packet when several packets are received at the same time.


You _want_ to update those registers on every packet. Otherwise the crappy 8139 chip breaks.

        Jeff



<Prev in Thread] Current Thread [Next in Thread>