netdev
[Top] [All Lists]

Re: [PATCH] #2: add more reset debug messages

To: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx
Subject: Re: [PATCH] #2: add more reset debug messages
From: mcgrof@xxxxxxxxxxxxxxxxxxxx (Luis R. Rodriguez)
Date: Tue, 10 Aug 2004 20:53:46 -0400
In-reply-to: <20040811002844.GH26262@xxxxxxxxxxxxxxxxxx>
Mail-followup-to: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx
Organization: Rutgers University Student Linux Users Group
References: <200408101824.28368.vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20040811002412.GG26262@xxxxxxxxxxxxxxxxxx> <20040811002844.GH26262@xxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
Denis,

Actually you have CVS access to prism54, if no one complains about these patches
(and I think no one will as they are trivial), just go ahead and commit these 
changes yourself. Please remember to update the ChangeLog too. 

After your changes go through I plan on starting to integrate the wpa work
I have (it can't wait any longer).

Thanks,

        Luis

On Tue, Aug 10, 2004 at 08:28:44PM -0400, Luis R. Rodriguez wrote:
> 
> Oh and I forgot to mention I think Jeff likes subjects in the format like:
> 
> [PATCH 1/2] prism54: space changes
> 
> and people also like followups (patch #2) for example, to be a reply to
> the original thread (for mail thread viewing purposes).
> 
>       Luis
> 
> On Tue, Aug 10, 2004 at 08:24:12PM -0400, Luis R. Rodriguez wrote:
> > 
> > Same here, looks good we'll just need a patch against the kernel tree
> > too for netdev.
> > 
> >     Luis
> > 
> > On Tue, Aug 10, 2004 at 06:24:28PM +0300, Denis Vlasenko wrote:
> > > Hi Luis,
> > > 
> > > On top of previous one:
> > > 
> > > * Some not needed NULL assignments removed
> > > * Add some more printks to reset code path
> > > * mgt_commit_list(): tell which oid has failed
> > > 
> > > All previous concerns about this patch are addressed
> > > (some of removed NULL assignments were indeed needed).
> > > 
> > > Please apply.
> > > --
> > > vda
> > 
> > 
> > 
> > -- 
> > GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E
> 
> -- 
> GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

<Prev in Thread] Current Thread [Next in Thread>