netdev
[Top] [All Lists]

Re: [PATCH 2.6] (3/3) vlan - use RCU

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6] (3/3) vlan - use RCU
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Tue, 03 Aug 2004 14:03:50 -0700
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040803134346.341e5636@xxxxxxxxxxxxxxxxxxxxx>
Organization: Candela Technologies
References: <20040803105017.0774e1db@xxxxxxxxxxxxxxxxxxxxx> <410FD348.9040301@xxxxxxxxxxxxxxx> <20040803134346.341e5636@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Stephen Hemminger wrote:
This patch makes VLAN use RCU for the group lookup and removes
the group_lock.  Since all operations that are done under group_lock
already have the rtnetlink semaphore (RTNL), the group_lock is unnecessary.
The result is the vlan code becomes basically lock free in the send/receive
path.

Looks good to me, but I'm fairly ignorant of RCU at this point.  Will
trust Stephen knows what he is doing :)

Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>