| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6] vlan - device refcount bug. |
| From: | Ben Greear <greearb@xxxxxxxxxxxxxxx> |
| Date: | Tue, 03 Aug 2004 13:36:16 -0700 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040803131425.503f8f45@xxxxxxxxxxxxxxxxxxxxx> |
| Organization: | Candela Technologies |
| References: | <20040803131425.503f8f45@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113 |
Stephen Hemminger wrote: If you rmmod a network device that is in a vlan, the system hangs waiting for the refcount to go to zero, because it is -1. The problem is that the vlan notifier does an extra dev_put in NETDEV_UNREGISTER case of notifier. Good catch. It would seem to me that it would be good to have a BUG() or similar to catch any instance of the reference count going negative. Ben -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6] cache align qdisc data, Stephen Hemminger |
|---|---|
| Next by Date: | Re: [PATCH 2.6] cache align qdisc data, Patrick McHardy |
| Previous by Thread: | [PATCH 2.6] vlan - device refcount bug., Stephen Hemminger |
| Next by Thread: | Re: [PATCH 2.6] vlan - device refcount bug., David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |