| To: | Ben Greear <greearb@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH 2.6] vlan - device refcount bug. |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Tue, 3 Aug 2004 13:14:25 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| Organization: | Open Source Development Lab |
| Sender: | netdev-bounce@xxxxxxxxxxx |
If you rmmod a network device that is in a vlan, the system hangs waiting
for the refcount to go to zero, because it is -1. The problem is that the
vlan notifier does an extra dev_put in NETDEV_UNREGISTER case of notifier.
Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>
diff -Nru a/net/8021q/vlan.c b/net/8021q/vlan.c
--- a/net/8021q/vlan.c 2004-08-03 13:13:33 -07:00
+++ b/net/8021q/vlan.c 2004-08-03 13:13:33 -07:00
@@ -645,7 +645,6 @@
ret = unregister_vlan_dev(dev,
VLAN_DEV_INFO(vlandev)->vlan_id);
- dev_put(vlandev);
unregister_netdevice(vlandev);
/* Group was destroyed? */
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2.6] netem limit not returned correctly, Stephen Hemminger |
|---|---|
| Next by Date: | Re: ksoftirqd uses 99% CPU triggered by network traffic (maybe RLT-8139 related), Pasi Sjoholm |
| Previous by Thread: | [PATCH 2.6] netem limit not returned correctly, Stephen Hemminger |
| Next by Thread: | Re: [PATCH 2.6] vlan - device refcount bug., Ben Greear |
| Indexes: | [Date] [Thread] [Top] [All Lists] |