netdev
[Top] [All Lists]

Re: patches

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: patches
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 29 Jul 2004 19:20:46 -0700
Cc: netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20040730012431.GA21253@xxxxxxxxxxxxxxxxxxx>
References: <20040729181948.5d36f47f.davem@xxxxxxxxxx> <20040730012431.GA21253@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 30 Jul 2004 11:24:31 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Here is the routing headers patch again.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Applied.

Based upon reading of the rest of the thread about
this patch I understand that:

1) Direction checking suggested by Yoshifuji is unecessary
   because on input segments_left will be zero in the type 0
   routing header.

2) Both ipv4 and ipv6 erroneously do the xfrm route lookup
   using the first hop destination not the final destination.
   And this needs to be fixed with a followon patch.

Is this correct?

<Prev in Thread] Current Thread [Next in Thread>