netdev
[Top] [All Lists]

Re: [PATCH]Fix adding SA through netlink(xfrm_user)

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [PATCH]Fix adding SA through netlink(xfrm_user)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 28 Jul 2004 19:07:28 -0700
Cc: nakam@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0407281134500.11200-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040729001058.48cd1791@localhost> <Xine.LNX.4.44.0407281134500.11200-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 28 Jul 2004 11:41:33 -0400 (EDT)
James Morris <jmorris@xxxxxxxxxx> wrote:

> On Thu, 29 Jul 2004, Masahide Nakamura wrote:
> 
> > When adding IPsec SA with PF_KEY (pfkey_add()),
> > xfrm_probe_algs() is called to make all algorithms valid.
> > However, it is missing to call it with netlink (xfrm_user) case and
> > it causes xfrm_aalg_get_byname() return NULL even if the name of
> > algorithm seems to be correct.
> 
> Looks ok, but odd that this has not been picked up before.

As discovered, this never got picked up before mostly
because the most popular user of xfrm_user (Openswan)
is still using PF_KEY to probe the algorithms.

Patch applied, arigato Masahide-san.

<Prev in Thread] Current Thread [Next in Thread>