netdev
[Top] [All Lists]

Re: Use NET_IP_ALIGN in acenic

To: Anton Blanchard <anton@xxxxxxxxx>
Subject: Re: Use NET_IP_ALIGN in acenic
From: Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx>
Date: 28 Jul 2004 02:37:25 -0400
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxx
In-reply-to: <20040724174348.GL4556@krispykreme>
References: <20040724174348.GL4556@krispykreme>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
>>>>> "Anton" == Anton Blanchard <anton@xxxxxxxxx> writes:

Anton> Use NET_IP_ALIGN in acenic driver. Also remove the 16 byte
Anton> padding, caches can be anywhere from 16 to 256 bytes and the
Anton> skb should be cacheline aligned already.

Hi Anton,

I don't have any objections to this one, however the main reason for
the 14 byte padding was to 32 bit align the IP header to avoid too
many misaligned loads rather than hitting any cache boundary.

Cheers,
Jes

<Prev in Thread] Current Thread [Next in Thread>