Re: [IPSEC] Missing unlock in policy timer

netdev

Re: [IPSEC] Missing unlock in policy timer

To:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [IPSEC] Missing unlock in policy timer
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Fri, 23 Jul 2004 13:34:28 -0700
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20040723110626.GA31264@xxxxxxxxxxxxxxxxxxx>
References:	<20040723110626.GA31264@xxxxxxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Fri, 23 Jul 2004 21:06:26 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> This is one of those cases where the cure is worse than the disease :)
> I added read locks in the policy timer to close an unlikely race, but
> I missed an unlock on the expire path which leads to all sort of weird
> things.
> 
> I'll stay away from the timers for a while :)

Hehe, applied.  Thanks Herbert.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[IPSEC] Missing unlock in policy timer, Herbert Xu Re: [IPSEC] Missing unlock in policy timer, David S. Miller <=

Previous by Date:	Re: [PATCH] pkt_cls.h incompatiables, Jamal Hadi Salim
Next by Date:	Re: [AH6] Disallow mutable bits after AH header, David S. Miller
Previous by Thread:	[IPSEC] Missing unlock in policy timer, Herbert Xu
Next by Thread:	Re: [PATCH] convert skge to pci_driver API (2nd try), Mirko Lindner
Indexes:	[Date] [Thread] [Top] [All Lists]