netdev
[Top] [All Lists]

Re: [PATCH] pkt_cls.h incompatiables

To: hadi@xxxxxxxx
Subject: Re: [PATCH] pkt_cls.h incompatiables
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Fri, 23 Jul 2004 11:00:07 -0400 (EDT)
Cc: shemminger@xxxxxxxx, davem@xxxxxxxxxx, arekm@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <1090593676.1128.25.camel@xxxxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20040722134522.4e7e0b07@xxxxxxxxxxxxxxxxxxxxx> <20040722.200426.99255296.yoshfuji@xxxxxxxxxxxxxx> <1090593676.1128.25.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
In article <1090593676.1128.25.camel@xxxxxxxxxxxxxxxx> (at 23 Jul 2004 10:41:16 
-0400), Jamal Hadi Salim <hadi@xxxxxxxx> says:

> > Solutions are, for example,
> >  to allocate new TCA_U32_xxx for rcnt and rhit,
> > or, 
> >  to rename TCA_U32_SEL to TCA_U32_OLS_SEL and allocate new value for 
> >  TCA_U32_SEL.
> 
> 
> we could do this, but since we are already fscking the ABI it is not
> valuable.

BTW, what's for rcnt etc.? I don't see the point. 

They're not (effectively) used in kernel.
I'd suggest to remove these things and to maintain the original ABI.

If rcnt etc. are for other purposes, such as statistics for userspace,
please allocate another structure / interface for it.

(And... cheking size is too strict;
we need to relax it to accept old binaries if we add something
at the tail of structure.)

Thanks.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>