netdev
[Top] [All Lists]

Re: [PATCH 2.6]: Make packet scheduler clock source configurable

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 22 Jul 2004 18:03:17 -0700
Cc: kaber@xxxxxxxxx, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx, devik@xxxxxx
In-reply-to: <41006344.3070402@xxxxxxxxx>
References: <40F34740.5040100@xxxxxxxxx> <1107.63.170.215.71.1089689716.squirrel@xxxxxxxxxxxx> <20040712205037.573411c0.davem@xxxxxxxxxx> <40F4862D.3070802@xxxxxxxxx> <40F4AC8B.40706@xxxxxxxxx> <20040721143110.4ab944bf.davem@xxxxxxxxxx> <41004F76.1080807@xxxxxxxxx> <20040722171752.341d2476.davem@xxxxxxxxxx> <41006150.9000702@xxxxxxxxx> <41006344.3070402@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 23 Jul 2004 03:00:52 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> Patrick McHardy wrote:
> > David S. Miller wrote:
> >> We could bug check this in psched calibration, in fact I think
> >> we should.
> > 
> > 
> > Done by this patch. I used BUG_ON instead of just printing a warning
> > because using packet schedulers after this error will cause a division
> > by zero.
> 
> Please drop this patch, psched_calibrate_clock already checks if
> rdelay > delay a couple of lines above.

Ok.

<Prev in Thread] Current Thread [Next in Thread>