| To: | James Morris <jmorris@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [IPCOMP6] Fix ICMP type check |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Thu, 22 Jul 2004 12:19:52 -0700 |
| Cc: | herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, xma@xxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.58.0407221025010.7557@xxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20040722113429.GA15083@xxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.58.0407221025010.7557@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Thu, 22 Jul 2004 10:25:24 -0400 (EDT)
James Morris <jmorris@xxxxxxxxxx> wrote:
> On Thu, 22 Jul 2004, Herbert Xu wrote:
>
> > It looks like IPCOMP was missed when the same problem was fixed in
> > AH/ESP.
>
> What about esp4/ah4/ipcomp? They look wrong too.
Those are testing something else, and I believe their tests
are correct. They are saying:
if (type != X || code != Y)
return;
in these cases Herbert is mentioning it is testing against multiple
possible settings of just "type".
Herbert, I'll apply your patch, thanks.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | pcmcia ether drivers can't be unloaded, Stephen Hemminger |
|---|---|
| Next by Date: | Re: [INET] Create enum of ECN bits, David S. Miller |
| Previous by Thread: | Re: [IPCOMP6] Fix ICMP type check, James Morris |
| Next by Thread: | [INET] Create enum of ECN bits, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |