netdev
[Top] [All Lists]

Re: [RFR] gianfar ethernet driver

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [RFR] gianfar ethernet driver
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 9 Jul 2004 00:35:37 +0100
Cc: Kumar Gala <kumar.gala@xxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, jamal <hadi@xxxxxxxxxx>
In-reply-to: <40EDD7F1.6090309@xxxxxxxxx>
References: <8F52CF1D-C916-11D8-BB6A-000393DBC2E8@xxxxxxxxxxxxx> <40E98FB8.4070900@xxxxxxxxx> <20040708231131.GA20305@xxxxxxxxxxxxx> <40EDD7F1.6090309@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Jul 08, 2004 at 07:25:37PM -0400, Jeff Garzik wrote:
> Christoph Hellwig wrote:
> >Are you sure someone ever tried building this driver modular?  The 
> >makefile
> >would try to build it into three separate modules, and they'd fail to load
> >due to unresolved cross-depencies..
> 
> 
> For embedded drivers isn't not uncommon that it's never used as a 
> module, so it wouldn't surprise me.

then it shouldn't be declare tristate at least.  But given that modularizig
a netdriver is trivial not doing so counts as a bug to me.


<Prev in Thread] Current Thread [Next in Thread>