netdev
[Top] [All Lists]

Re: pskb change in dst->output

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: pskb change in dst->output
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 8 Jul 2004 07:28:05 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <Xine.LNX.4.44.0407071013080.26759-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040707130652.GA26822@xxxxxxxxxxxxxxxxxxx> <Xine.LNX.4.44.0407071013080.26759-100000@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Wed, Jul 07, 2004 at 10:58:21AM -0400, James Morris wrote:
> 
> >  All of the dst->output functions already assumed that they have
> > exclusive access to the skb. This is justified because all callers to
> > dst_output() makes sure that the packet is neither shared nor cloned.
> 
> Cloned skbs are regularly passed to dst_output(), thus we need to use the 
> double pointer for skb_checksum_help() in case the skb is replaced.

OK.  Can you please tell me which caller of dst_output() passes
a cloned skb to it?

I need to know this because if this is the case, we need fix the various
IPsec output functions to copy the skb.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>