netdev
[Top] [All Lists]

Re: [PATCH] fix tcp_default_win_scale.

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] fix tcp_default_win_scale.
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 7 Jul 2004 01:16:00 +0200
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, ahu@xxxxxxx, acme@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, alessandro.suardi@xxxxxxxxxx, phyprabab@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20040706132426.097f71e6.davem@xxxxxxxxxx>
References: <32886.63.170.215.71.1088564087.squirrel@xxxxxxxxxxxx> <20040629222751.392f0a82.davem@xxxxxxxxxx> <20040630152750.2d01ca51@xxxxxxxxxxxxxxxxxxxxx> <20040630153049.3ca25b76.davem@xxxxxxxxxx> <20040701133738.301b9e46@xxxxxxxxxxxxxxxxxxxxx> <20040701140406.62dfbc2a.davem@xxxxxxxxxx> <20040702013225.GA24707@xxxxxxxxxxxxxxxx> <20040706093503.GA8147@xxxxxxxxxxxxxxx> <20040706114741.1bf98bbe@xxxxxxxxxxxxxxxxxxxxx> <20040706132426.097f71e6.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
I would not change anything, just suggest that users who sit
behind such a broken device do

echo 0 > /proc/sys/net/ipv4/tcp_window_scaling

and yell loudly at their ISPs to get this fixed. Crippling the stack
by default just to work around such obvious bugs would be wrong.

In the past there were similar bugs with broken VJ header compression
algorithms that also corrupted window scaling. We just ignored
these and suggested to the users to turn it off. That worked fine.

[btw it's quite possible that this isn't a firewall, but also
some kind of header compression that is doing the wrong thing]

-Andi

<Prev in Thread] Current Thread [Next in Thread>