netdev
[Top] [All Lists]

Re: [IPCOMP] Exclude IPCOMP header from props.header_len

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [IPCOMP] Exclude IPCOMP header from props.header_len
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 6 Jul 2004 14:11:05 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040706123127.GA18271@xxxxxxxxxxxxxxxxxxx>
References: <20040706123127.GA18271@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 6 Jul 2004 22:31:27 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> This patch changes the value of props.header_len for IPCOMP to
> exclude the IPCOMP header.  The reason is that the IPCOMP header
> is added only if the packet is compressible.  That is, if the
> size of the compressed payload plus the size of the IPCOMP header
> is less than that of the original payload.
> 
> This means that the IPCOMP encapsulation does not impose any
> overhead at all as far as the MTU is concerned.  The current
> code incorrectly reduces the MTU by the size of the IPCOMP
> header.
> 
> As a side-effect, this means that we don't have to move the
> IP header around when IPCOMP is used.

Very nice patch Herbert, applied.

<Prev in Thread] Current Thread [Next in Thread>