netdev
[Top] [All Lists]

Re: 2.6.7: sk98lin unload oops

To: Bernd Schubert <bernd-schubert@xxxxxx>
Subject: Re: 2.6.7: sk98lin unload oops
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 4 Jul 2004 23:04:46 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200407050001.46489.bernd-schubert@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Bernd Schubert <bernd-schubert@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
References: <200407041342.18821.bernd-schubert@xxxxxx> <200407042028.59047.bernd-schubert@xxxxxx> <20040704184404.GA7262@xxxxxxxxxxxxx> <200407050001.46489.bernd-schubert@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Mon, Jul 05, 2004 at 12:01:35AM +0200, Bernd Schubert wrote:
> [from your other mail]
> > the previous one) makes it work unless you change the interface name
> > manually, but as Linux explicitly allows that the interface is
> > fundamentally broken and probably should just go away.
> 
> Unfortunality we rename all interfaces using ifrename to make sure that the 
> interface names won't change with different kernel versions (we have this 
> problem when we switch between 2.4. and 2.6.). So it is normal that the oops 
> occurs on unloading the modules?

Well, the problem is that someone smoked bad crack when designing the sk98lin
procfs interface ;-)  We should probably just kill it and find a better way
to export the information if nessecary.  I'll take a look at that.

> Btw, on 22th June I got another skge.c patch from Herbert Xu to fix another 
> oops:
> 
> http://lkml.org/lkml/2004/6/22/44
> 
> This patch applies fine on top of your new versions (with 400 lines offset), 
> maybe this patch should also be included into the current BK tree?

Jeff already merged that patch.

<Prev in Thread] Current Thread [Next in Thread>