netdev
[Top] [All Lists]

Re: [Openswan dev] IPComp

To: Paul Wouters <paul@xxxxxxxxxxxxx>
Subject: Re: [Openswan dev] IPComp
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 3 Jul 2004 21:37:32 +1000
Cc: "D. Hugh Redelmeier" <hugh@xxxxxxxxxx>, dev@xxxxxxxxxxxxxxxxxx, Dominique Blas <ml@xxxxxxxx>, jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0407031301460.27704-100000@xxxxxxxxxxxxxxxxxxxxxxx>
References: <E1BgYk6-0007M3-00@xxxxxxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.44.0407031301460.27704-100000@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Sat, Jul 03, 2004 at 01:02:56PM +0200, Paul Wouters wrote:
> 
> He seems to have generic memory problems though, so I don't think this is an 
> openswan or kernel ipsec bug.

He's probably having a memory fragmentation problem, but allocating
64K physically contiguous memory is something that should never be
done over and over again.  As the IPCOMP init function is called
regularly, this needs to be fixed.

I haven't looked at the IPCOMP code in detail, but I'd guess that
we're allocating 64K as the largest IP packet size is 64K.

Would it be possible to adjust the size of the buffer according
to the packet size and allocate it in ipcomp_input()/ipcomp_output()
instead?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>