netdev
[Top] [All Lists]

Re: [XFRM] Convert XFRM_MSG_* macros to an enum

To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [XFRM] Convert XFRM_MSG_* macros to an enum
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 3 Jul 2004 20:10:58 +1000
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040703100208.GA16339@xxxxxxxxxxxxxxxxxxx>
References: <20040703095215.GA16195@xxxxxxxxxxxxxxxxxxx> <20040703.190042.70899669.yoshfuji@xxxxxxxxxxxxxx> <20040703100208.GA16339@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Sat, Jul 03, 2004 at 08:02:08PM +1000, herbert wrote:
> 
> I think such applications are broken.
> 
> They should compile with headers that define these symbols and
> test for their support at run-time.
> 
> Applications should not detect kernel features at compile-time.

Well, I guess there are always going to be broken applications.
I'd move on rather than dwell on this point.

So here is an add-on patch to add the macros.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>