netdev
[Top] [All Lists]

Re: Check connect address in NETLINK

To: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Subject: Re: Check connect address in NETLINK
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 30 Jun 2004 22:08:28 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040630120045.GA7973@xxxxxxxxxxxxx>
References: <20040628231439.GA3021@xxxxxxxxxxxxxxxxxxx> <20040629082252.GA26866@xxxxxxxxxxxxx> <20040629084552.GA6202@xxxxxxxxxxxxxxxxxxx> <20040629111433.GA28463@xxxxxxxxxxxxx> <20040629111833.GA22880@xxxxxxxxxxxxxxxxxxx> <20040630112751.GA31160@xxxxxxxxxxxxxxxxxxx> <20040630120045.GA7973@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Wed, Jun 30, 2004 at 04:00:45PM +0400, Alexey Kuznetsov wrote:
> 
> > +   if (sock->sk_socket->state == SS_CONNECTED &&
> > +       nlk->dst_pid != nlk_sk(ssk)->pid) {
> 
> No-no-no! sock->sk_socket can be NULL at this point.
> 
> You can use sock->sk_state =  TCP_ESTABLISHED, forxample.

OK.  Can you give me a code path that allows sk_socket to be NULL
at this point?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>