netdev
[Top] [All Lists]

[PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()

To: Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Subject: [PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()
From: Olaf Hering <olh@xxxxxxx>
Date: Mon, 28 Jun 2004 20:18:43 +0200
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt und vi sind doch schneller als Notes
net/decnet/dn_nsp_in.c:534: warning: comparison is always false due to limited 
range of data type

char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11


--- ./net/decnet/dn_nsp_in.c
+++ ./net/decnet/dn_nsp_in.c    2004/06/28 18:11:40
@@ -504,7 +504,7 @@
        struct dn_scp *scp = DN_SK(sk);
        unsigned short segnum;
        unsigned char lsflags;
-       char fcval;
+       signed char fcval;
        int wake_up = 0;
        char *ptr = skb->data;
        unsigned char fctype = scp->services_rem & NSP_FC_MASK;
-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice(), Olaf Hering <=