netdev
[Top] [All Lists]

CodingStyle: while ((a=b))

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: CodingStyle: while ((a=b))
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Sat, 26 Jun 2004 16:42:21 -0700
Cc: chas@xxxxxxxxxxxxxxxx, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxx>
In-reply-to: <20040626162641.00786ed6.davem@xxxxxxxxxx>
References: <200406262245.i5QMjn65009470@xxxxxxxxxxxxxxxxxxxxxxx> <20040626225230.GA12698@xxxxxxxxxxxxxxxxxxxxx> <20040626162641.00786ed6.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, Jun 26, 2004 at 04:26:41PM -0700, David S. Miller wrote:

> I think warning for the ((a=b)) case is annoying but not annoying
> enough to fight against it :)

Whatever the case, even if I don't like it I would rather see it
consistent.

Maybe Linus can comment as to whether or not we officially
(Documentation/CodingStyle update) want to change things like:

    while ((a=b)) to while ((a=b) != 0)

and similar throughout the code?


  --cw

<Prev in Thread] Current Thread [Next in Thread>