Re: [PATCH][ATM]: fix sparse checker warnings

[Chris Wedgwood <cw@xxxxxxxx>]

On Sat, Jun 26, 2004 at 06:45:50PM -0400, chas williams (contractor) wrote:

> diff -Nru a/net/atm/br2684.c b/net/atm/br2684.c
> - --- a/net/atm/br2684.c      2004-06-22 14:04:02 -07:00

forwarding mangled the patch

> +++ b/net/atm/br2684.c        2004-06-22 14:04:02 -07:00
> @@ -562,7 +562,7 @@
>       atmvcc->push = br2684_push;
>       skb_queue_head_init(&copy);
>       skb_migrate(&atmvcc->sk->sk_receive_queue, &copy);

> - -   while ((skb = skb_dequeue(&copy))) {
> +     while ((skb = skb_dequeue(&copy)) != NULL) {

I know it's a matter of style, but I really hate the 'assignment in
conditional' warning sparse spews out, especially when many people,
myself included really do write while ((a = b)) --- the extra
parentheses as a compromise to keep gcc quiet.


   --cw