netdev
[Top] [All Lists]

[IPSEC] Drop bogus NAT-T printks in esp_input

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [IPSEC] Drop bogus NAT-T printks in esp_input
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 26 Jun 2004 20:07:18 +1000
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040626015715.GA16496@xxxxxxxxxxxxxxxxxxx>
References: <20040625121147.GA11231@xxxxxxxxxxxxxxxxxxx> <20040625123527.GA11685@xxxxxxxxxxxxxxxxxxx> <20040625103928.3b1b3275.davem@xxxxxxxxxx> <20040626015715.GA16496@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Sat, Jun 26, 2004 at 11:57:15AM +1000, herbert wrote:
> 
> However, printing a warning and then continuing is definitely wrong.
> So expect a follow-up patch to drop the packet when encap_type is
> unknown in esp_input.

Here is the patch to drop the packet if encap_type is unknown.
I've also removed the other two bogus printk's as they cannot
occur (printing a message is the last thing you want to do even
if they did occur :).

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>