netdev
[Top] [All Lists]

[PATCH 2.6.7-mm1 3/4] via-velocity: ordering of Rx descriptors operation

To: netdev@xxxxxxxxxxx
Subject: [PATCH 2.6.7-mm1 3/4] via-velocity: ordering of Rx descriptors operations
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Mon, 21 Jun 2004 23:59:46 +0200
Cc: alan@xxxxxxxxxx, akpm@xxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <20040621235808.A9979@xxxxxxxxxxxxxxxxxxxxxxxxxx>; from romieu@xxxxxxxxxxxxx on Mon, Jun 21, 2004 at 11:58:08PM +0200
References: <20040621235615.A7869@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20040621235808.A9979@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
Force strict ordering of operations on Rx descriptors to avoid any issue
related to inline optimization.

diff -puN drivers/net/via-velocity.c~via-velocity-80 drivers/net/via-velocity.c
--- linux-2.6.7/drivers/net/via-velocity.c~via-velocity-80      2004-06-21 
21:51:15.000000000 +0200
+++ linux-2.6.7-fr/drivers/net/via-velocity.c   2004-06-21 22:20:35.000000000 
+0200
@@ -993,6 +993,8 @@ static inline void velocity_give_many_rx
        if (vptr->rd_filled < 4)
                return;
 
+       wmb();
+
        unusable = vptr->rd_filled | 0x0003;
        dirty = vptr->rd_dirty - unusable + 1;
        for (avail = vptr->rd_filled & 0xfffc; avail; avail--) {

_

<Prev in Thread] Current Thread [Next in Thread>