| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [PATCH] cleanup large frame handling for natsemi.c |
| From: | Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> |
| Date: | Sun, 20 Jun 2004 14:14:59 +0200 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.6) Gecko/20040510 |
Hi,The DP83815/6 by default rejects frames longer that 1518 bytes (including crc). This means that a special flag must be set for 8021q - otherwise mtu sized packets are dropped. The current driver enables this flag only if the buffer size is above 1536 bytes - this is wrong. Additionally, the nic writes up to two bytes behind the indicated end of the buffer. This is not documented, thus I've added 64 bytes - just to be safe. The patch also removes RX_OFFSET from the rx buffer allocation: The nic can only receive to 32-bit aligned addresses, it's a left over from a skeleton driver. Jeff, could you apply it? I've stress tested vlan for an hour with tbench and parallel kernel compiles, not obvious problems. -- Manfred |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [6/9][PATCH 2.6] Fix Tx engine race for good, Roger Luethi |
|---|---|
| Next by Date: | [PATCH] convert skge to pci_driver API (2nd try), Christoph Hellwig |
| Previous by Thread: | [PATCH] more DECLARE_MUTEX() in headers crap, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] cleanup large frame handling for natsemi.c, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |