| To: | jgarzik@xxxxxxxxx |
|---|---|
| Subject: | [PATCH] ethtool_get_regs copy right number of bytes to user |
| From: | Chris Wright <chrisw@xxxxxxxx> |
| Date: | Tue, 15 Jun 2004 15:55:41 -0700 |
| Cc: | netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5i |
If regs.len is smaller than reglen it's possible to copy more bytes out
than the user asked for.
Signed-off-by: Chris Wright <chrisw@xxxxxxxx>
===== net/core/ethtool.c 1.14 vs edited =====
--- 1.14/net/core/ethtool.c 2004-06-02 14:54:28 -07:00
+++ edited/net/core/ethtool.c 2004-06-13 12:59:15 -07:00
@@ -157,7 +157,7 @@
if (copy_to_user(useraddr, ®s, sizeof(regs)))
goto out;
useraddr += offsetof(struct ethtool_regs, data);
- if (copy_to_user(useraddr, regbuf, reglen))
+ if (copy_to_user(useraddr, regbuf, regs.len))
goto out;
ret = 0;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [0/9] via-rhine: Major surgery, Roger Luethi |
|---|---|
| Next by Date: | Re: Allow IP header alignment to be overriden, Anton Blanchard |
| Previous by Thread: | [0/9] via-rhine: Major surgery, Roger Luethi |
| Next by Thread: | Re: [Prism54-devel] GUPD (Grand Unified Prism54 Driver) Open discussion, Luis R. Rodriguez |
| Indexes: | [Date] [Thread] [Top] [All Lists] |