Re: 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1

["David S. Miller" <davem@xxxxxxxxxx>]

On Mon, 14 Jun 2004 14:22:16 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> OK, in that case either they all need to check whether idev is
> NULL before doing this or we'll need to fix ->ifdown to set the
> dev to something other than NULL.

That's correct, I don't exactly how to deal with that race
just yet.

> BTW in looking at this I've found two bugs in the dst code wrt
> cleaning up net devices.
> 
> 1. The code in dst_dev_event relies on the entries with dev in it
> getting onto the garbage list before it is called.  Unfortunately
> for routing entries, the flushing is done asynchronusly so it is
> entirely possible for the entries to get onto the garbage list after
> dst_dev_event has been called twice (DOWN and then UNREGISTER).
> 
> This is not fatal though since another GC run will pick them up in
> at most two minutes.  But the user may well be alarmed by those
> dreaded "waiting for..." errors.

Right.

> 2. dst_dev_event doesn't clean up dst->child at all.

DST object is disassembled at GC time, so I classift this just
like case #1 above.