[Top] [All Lists]

Re: [PATCH] e1000 module parameter incompatiablity

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] e1000 module parameter incompatiablity
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Tue, 8 Jun 2004 12:39:33 -0700
Cc: "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, cramerj <cramerj@xxxxxxxxx>, "Ronciak, John" <john.ronciak@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <40C607D9.5090506@xxxxxxxxx>
Organization: Open Source Development Lab
References: <468F3FDA28AA87429AD807992E22D07E0158A1CD@orsmsx408> <20040608110420.3b93338d@xxxxxxxxxxxxxxxxxxxxx> <40C607D9.5090506@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 08 Jun 2004 14:39:21 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > E1000 driver is mixing new style 'module_param' with old style 'MODULE_PARM'
> > this generates the runtime warning
> >     e1000: Ignoring new-style parameters in presence of obsolete ones
> > and prevents using module parameters to set ring size.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>
> why not fix the others?

Cause their buried in ugly macros in another place.

<Prev in Thread] Current Thread [Next in Thread>