Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing

[Andreas Schwab <schwab@xxxxxxx>]

"David S. Miller" <davem@xxxxxxxxxx> writes:

> On Sat, 05 Jun 2004 23:21:53 +0200
> Andreas Schwab <schwab@xxxxxxx> wrote:
>
>> "David S. Miller" <davem@xxxxxxxxxx> writes:
>> 
>> > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not
>> > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected
>> > value all 1's thus breaking the tests for unexpected flags completely.
>> 
>> ??? Where do you get ~MSG_CMSG_COMPAT from?
>
> Olaf's patch, it said:
>
> -     if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC))
> +     if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT))

Yes, and where is the problem?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."