netdev
[Top] [All Lists]

4/x: [NETDRV] Merge register_netdev calls

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: 4/x: [NETDRV] Merge register_netdev calls
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 5 Jun 2004 15:27:37 +1000
Cc: netdev@xxxxxxxxxxx
In-reply-to: <40BE3778.1020404@xxxxxxxxx>
References: <20040313025859.GA8186@xxxxxxxxxxxxxxxxxxx> <405C294D.5040508@xxxxxxxxx> <20040520111937.GA21804@xxxxxxxxxxxxxxxxxxx> <20040522074435.GA9628@xxxxxxxxxxxxxxxxxxx> <20040529084109.GA13032@xxxxxxxxxxxxxxxxxxx> <40BE3778.1020404@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1+cvs20040105i
On Wed, Jun 02, 2004 at 04:24:24PM -0400, Jeff Garzik wrote:
> >
> >Here is the patch that adds register_ei_netdev which lets us get rid of
> >some of the duplicated printk's in the 8390 drivers.
> 
> Patch looks OK, but I would prefer to reject it, and merge it later when 
> an accompanying patch appears using this new function.

Actually I've decided to scrap it in favour of a more generic
ether_print_info() that can be used by all Ethernet drivers.

So in its place I present the following patch that merges duplicate
register_netdev calls by moving them to the probe function.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>