netdev
[Top] [All Lists]

Re: [PATCH] remove net driver ugliness that sparse complains about

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] remove net driver ugliness that sparse complains about
From: Andreas Schwab <schwab@xxxxxxx>
Date: Sat, 29 May 2004 20:31:17 +0200
Cc: Netdev <netdev@xxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, Arjan van de Ven <arjanv@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxx>
In-reply-to: <40B8D2F8.6090905@xxxxxxxxx> (Jeff Garzik's message of "Sat, 29 May 2004 14:14:16 -0400")
References: <40B8D2F8.6090905@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux)
Jeff Garzik <jgarzik@xxxxxxxxx> writes:

> @@ -3680,7 +3680,7 @@
>       case SIOCETHTOOL:
>               return bond_ethtool_ioctl(bond_dev, ifr);
>       case SIOCGMIIPHY:
> -             mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> +             mii = if_mii(&ifr);
>               if (!mii) {
>                       return -EINVAL;
>               }
> @@ -3691,7 +3691,7 @@
>                * We do this again just in case we were called by SIOCGMIIREG
>                * instead of SIOCGMIIPHY.
>                */
> -             mii = (struct mii_ioctl_data *)&ifr->ifr_data;
> +             mii = if_mii(&ifr);

These two look wrong, too many &.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


<Prev in Thread] Current Thread [Next in Thread>