Re: [PATCH]Add new IPv6 MIBs counters support through netlink

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040526134415.483a6384.davem@xxxxxxxxxx> (at Wed, 26 May 2004 
13:44:15 -0700), "David S. Miller" <davem@xxxxxxxxxx> says:

> On Wed, 26 May 2004 13:42:23 -0700
> Shirley Ma <xma@xxxxxxxxxx> wrote:
> 
> > Yes, same structure ip_stats applys to IPv4 as well.
> 
> Great, patch applied.

I failed to comment because I've just waken up...

Hmm, why are you so hurrying?
It on -rc stage and 2.6.7 is coming.
Each people should moderate yourself...

Sorry, please exclude it for now.

Comments:

Without adding support for u64 counter, it does not make sense to add
new interface. You can add new counter to the end of the structures.

This also contains per-interface statistics support.
(I rember that you said that) we should add idev into an route and avoid
get/put idev.

I strongly do not want to poeple to change their code twice to support
draft-ietf-ipv6-rfc2011-update-XX.txt.

I personally think this should be included in 2.7 phase.

--yoshfuji @ morning