[Top] [All Lists]

Re: [PATCH] fix BUG in tg3_tx

To: Greg Banks <gnb@xxxxxxx>
Subject: Re: [PATCH] fix BUG in tg3_tx
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 24 May 2004 00:40:45 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040524072657.GC27177@xxxxxxx>
References: <20040524072657.GC27177@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 24 May 2004 17:26:58 +1000
Greg Banks <gnb@xxxxxxx> wrote:

> The tg3 transmit code assumes that tg3_tx() will never have to clean
> up part of an skb queued for transmit.  This assumption is wrong;

Greg, perhaps my reading of the tg3 chip docs is different
from yours.  The hardware is NEVER supposed to do this.

Or is there an errata in some chip versions?

I've never triggered that BUG() assertion on any of my
hardware, ever.

<Prev in Thread] Current Thread [Next in Thread>