| To: | Andrew Morton <akpm@xxxxxxxx> |
|---|---|
| Subject: | Re: MSEC_TO_JIFFIES is messed up... |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Wed, 12 May 2004 16:24:53 -0400 |
| Cc: | Ingo Molnar <mingo@xxxxxxx>, davidel@xxxxxxxxxxxxxxx, greg@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040512132050.6eae6905.akpm@xxxxxxxx> |
| References: | <20040512020700.6f6aa61f.akpm@xxxxxxxx> <20040512181903.GG13421@xxxxxxxxx> <40A26FFA.4030701@xxxxxxxxx> <20040512193349.GA14936@xxxxxxx> <Pine.LNX.4.58.0405121247011.11950@xxxxxxxxxxxxxxxxxxxxxxx> <20040512200305.GA16078@xxxxxxx> <20040512132050.6eae6905.akpm@xxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 |
Andrew Morton wrote: Yes, that's a correct optimisation. This is simply a namespace clash. Agreed. How about we do: #if HZ=1000 #define MSEC_TO_JIFFIES(msec) (msec) #define JIFFIES_TO_MESC(jiffies) (jiffies) #elif HZ=100 #define MSEC_TO_JIFFIES(msec) (msec * 10) #define JIFFIES_TO_MESC(jiffies) (jiffies / 10) #else #define MSEC_TO_JIFFIES(msec) ((HZ * (msec) + 999) / 1000) #define JIFFIES_TO_MSEC(jiffies) ... #endif in some kernel-wide header then kill off all the private implementations? include/linux/time.h. One of the SCTP people already did this, but I suppose it's straightforward to reproduce.
Jeff
|
| Previous by Date: | Re: MSEC_TO_JIFFIES is messed up..., Andrew Morton |
|---|---|
| Next by Date: | question about ip_build_xmit, linux lover |
| Previous by Thread: | Re: MSEC_TO_JIFFIES is messed up..., Ingo Molnar |
| Next by Thread: | Re: MSEC_TO_JIFFIES is messed up..., Andrew Morton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |