netdev
[Top] [All Lists]

Re: PCI memory reservation failure - 2.4/2.6

To: "Alec H. Peterson" <ahp@xxxxxxxxxxxx>
Subject: Re: PCI memory reservation failure - 2.4/2.6
From: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Date: Wed, 12 May 2004 23:07:29 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, Dominik Brodowski <linux@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <BDD74A21E0B47FEAC3AB8A10@[192.168.0.100]>
References: <BDD74A21E0B47FEAC3AB8A10@[192.168.0.100]>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.4.1) Gecko/20031114
Alec H. Peterson wrote:

+ #if 1
+ if (!(type & IORESOURCE_IO) && (((end - start) < BRIDGE_SIZE_MIN) ||
+             (start & (end - start))))
+       {
+ printk(KERN_INFO "yenta %s: Preassigned resource start %lx end %lx too small or not aligned.\n", socket->dev->slot_name, start, end);
+                 res->start = res->end = 0;
+ }

I'm not sure if this is the right approach - what if a bios intentionally assigns a small area? It's dangerous to override the BIOS setting. I'd prefer a kernel command line parameter / module parameter / dmi based override instead of an unconditional override based on the minimum size.
I'll think about it.

--
   Manfred


<Prev in Thread] Current Thread [Next in Thread>