netdev
[Top] [All Lists]

Re: MSEC_TO_JIFFIES is messed up...

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: MSEC_TO_JIFFIES is messed up...
From: Ingo Molnar <mingo@xxxxxxx>
Date: Wed, 12 May 2004 21:33:49 +0200
Cc: Greg KH <greg@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Netdev <netdev@xxxxxxxxxxx>
In-reply-to: <40A26FFA.4030701@xxxxxxxxx>
References: <20040512020700.6f6aa61f.akpm@xxxxxxxx> <20040512181903.GG13421@xxxxxxxxx> <40A26FFA.4030701@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
* Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> >Woah, that's new.  And wrong.  The code in include/asm-i386/param.h that
> >says:
> >     # define JIFFIES_TO_MSEC(x)     (x)
> >     # define MSEC_TO_JIFFIES(x)     (x)
> >
> >Is not correct.  Look at kernel/sched.c for verification of this :)
> 
> 
> Yes, that is _massively_ broken.

why is it wrong?

        Ingo

<Prev in Thread] Current Thread [Next in Thread>